fix(core): DinD issues #141, #329

[deeninetyone]

Fix #141 - find IP from custom network if the container is not using the default network
Close #329 - This seems fixed in the underlying docker libraries.
Improve support for Docker in Docker running on a custom network, by attempting to find the right custom network and use it for new containers. This adds support for using testcontainers-python running the GitHub Actions Runner Controller to run self-hosted actions runners on prem, when you run your workflows in containers.

[sean-hernon]

Any movement on merging this? I am doing something similar, to index by the custom network id instead of bridge. Would be nice to delete my own workarounds.

[damianoct]

any updates? we need to have testcontainers working properly in DIND environments

[VerdantForge]

Also interested in updates on this issue

[covatic-john]

Trying to get docker container in container running in bitbucket and struggling with it
I am sure that this is to do with the sock or internal host. Any pointers please

self = <docker.transport.unixconn.UnixHTTPConnection object at 0x7f4b610548e0>

def connect(self):

    sock = socket.socket(socket.AF_UNIX, socket.SOCK_STREAM)

    sock.settimeout(self.timeout)

  sock.connect(self.unix_socket)

E FileNotFoundError: [Errno 2] No such file or directory

/usr/local/lib/python3.10/site-packages/docker/transport/unixconn.py:27: FileNotFoundError

[alexanderankin]

i was able to run the test suite in dind while testing compose. what does dind mean for folks here? pardon my ignorance - but want to clarify so i can understand how to manually test. i do see that there is a test here. i am adding 4.1.0 because since we have code here, we can test and merge with relatively low consequences

[alexanderankin]

Maintainers are allowed to edit this pull request.

thank you, i will try to rebase this to get it to apply cleanly if i am able to make sense of the changes.

[deeninetyone]

Maintainers are allowed to edit this pull request.

thank you, i will try to rebase this to get it to apply cleanly if i am able to make sense of the changes.

It fixes the case where the container you are running in has a custom network (not the default one). In this case, the library needs to try to find the correct network and join the test container to the same network, or the container you're running in cannot contact the test container.

[totallyzen]

@deeninetyone thanks for the contrib! Looks promising and makes a lot of sense!

I have two asks:

• can you include tc.host in the "user knows best" check? It's been attempted in the init function so you might want to touch that too to make sure we're doing this in a single place
• can you make the new addition more structured around functions? these nested if/for/if/for make the code hard to read.

For the latter, my suggestion would be that you isolate the try-catch block into a function and instead of modifying kwargs from deep within the loop

• your new function would be something like def find_host_network() -> Optional[str]:
• then you'd do "user knows best, OR try to find host network, and if found one, alter the kwargs

EDIT: if you don't have the time, just say so, I'll backport my suggestion (I have no intention of stealing your thunder)

EDIT 2:

Maintainers are allowed to edit this pull request.

Right 😂

[totallyzen]

LGTM, thanks for the fix! ❤️