Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raise an exception when docker compose fails to start #258

Closed
wants to merge 4 commits into from
Closed

raise an exception when docker compose fails to start #258

wants to merge 4 commits into from

Conversation

bitplane
Copy link
Contributor

What happened

If my docker-compose.yml has errors and I'm testing it using testcontainers, no error is reported

What should happen

A ContainerStartException should be raised if docker-compose fails to start.

Fix

Get the return code, raise exception if nonzero. See test and small change

tillahoffmann
tillahoffmann approved these changes Oct 30, 2022
View reviewed changes
Copy link
Collaborator

@tillahoffmann tillahoffmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@bitplane bitplane force-pushed the compose-file-fail-start branch from d042e03 to 7e78844 Compare January 11, 2023 16:40
@bitplane bitplane force-pushed the compose-file-fail-start branch from 7e78844 to 47c3503 Compare January 11, 2023 16:55
@bitplane
Copy link
Contributor Author

bitplane commented Jan 11, 2023 •
edited
Loading

In case it's helpful to anyone else, to fix this old patch I did this:

  1. Rebased to get rid of any changes after mine (I'd done git merge master a couple of times, so had to rebase on top of the change after the last merge commit). THAT_COMMIT is now the last change before mine were applied
  2. Move the git diff THAT_COMMIT --name-only files into the new place with git mv
  3. Commit the changes, then git rebase -i THAT_COMMIT again, and rearrange it so the commit with the git mv happens before all other commits
  4. Now git rebase master. Get a merge conflict on the mv commit. so just skip it since it already happened in master

My subsequent patches applied cleanly with no merge conflicts. :)

alexanderankin added a commit that referenced this pull request Mar 20, 2024
@alexanderankin
raise an exception when docker compose fails to start #258
1d57547
@alexanderankin alexanderankin mentioned this pull request Mar 20, 2024
Merged
alexanderankin added a commit that referenced this pull request Mar 20, 2024
@alexanderankin @bitplane
fix(core): raise an exception when docker compose fails to start #258 (…
d61af38 
…#485)

see #258 for background

Co-authored-by: Gareth Davidson <[email protected]>
@alexanderankin
Copy link
Member

closing in favor of #485

@github-actions github-actions bot mentioned this pull request Mar 20, 2024
Merged
alexanderankin pushed a commit that referenced this pull request Mar 24, 2024
@github-actions
chore(main): release testcontainers 4.2.0 (#484)
e962189 
🤖 I have created a release *beep* *boop*
---


##
[4.2.0](testcontainers-v4.1.0...testcontainers-v4.2.0)
(2024-03-24)


### Features

* support influxdb
([#413](#413))
([13742a5](13742a5))


### Bug Fixes

* **arangodb:** tests to pass on ARM CPUs - change default image to
3.11.x where ARM image is published
([#479](#479))
([7b58a50](7b58a50))
* **core:** DinD issues
[#141](#141),
[#329](#329)
([#368](#368))
([b10d916](b10d916))
* **core:** raise an exception when docker compose fails to start
[#258](#258)
([#485](#485))
([d61af38](d61af38))
* **core:** use auto_remove=True with reaper instance
([#499](#499))
([274a400](274a400))
* **docs:** update the non-existent main.yml badge
([#493](#493))
([1d10c1c](1d10c1c))
* Fix the return type of `DockerContainer.get_logs`
([#487](#487))
([cd72f68](cd72f68))
* **keycloak:** tests on aarch64, use image from [jboss -&gt; quay],
change supported version [16+ -> 18+]
([#480](#480))
([5758310](5758310))
* **postgres:** doctest
([#473](#473))
([c9c6f92](c9c6f92))
* read the docs build works again
([#496](#496))
([dfd1781](dfd1781))
* readthedocs build - take 1
([#495](#495))
([b3b9901](b3b9901))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
bearrito pushed a commit to bearrito/testcontainers-python that referenced this pull request Mar 30, 2024
@alexanderankin @bitplane
fix(core): raise an exception when docker compose fails to start test…
bcbfe65 
…containers#258 (testcontainers#485)

see testcontainers#258 for background

Co-authored-by: Gareth Davidson <[email protected]>
bearrito pushed a commit to bearrito/testcontainers-python that referenced this pull request Mar 30, 2024
@github-actions
chore(main): release testcontainers 4.2.0 (testcontainers#484)
f83b8f1 
🤖 I have created a release *beep* *boop*
---


##
[4.2.0](testcontainers/testcontainers-python@testcontainers-v4.1.0...testcontainers-v4.2.0)
(2024-03-24)


### Features

* support influxdb
([testcontainers#413](testcontainers#413))
([13742a5](testcontainers@13742a5))


### Bug Fixes

* **arangodb:** tests to pass on ARM CPUs - change default image to
3.11.x where ARM image is published
([testcontainers#479](testcontainers#479))
([7b58a50](testcontainers@7b58a50))
* **core:** DinD issues
[testcontainers#141](testcontainers#141),
[testcontainers#329](testcontainers#329)
([testcontainers#368](testcontainers#368))
([b10d916](testcontainers@b10d916))
* **core:** raise an exception when docker compose fails to start
[testcontainers#258](testcontainers#258)
([testcontainers#485](testcontainers#485))
([d61af38](testcontainers@d61af38))
* **core:** use auto_remove=True with reaper instance
([testcontainers#499](testcontainers#499))
([274a400](testcontainers@274a400))
* **docs:** update the non-existent main.yml badge
([testcontainers#493](testcontainers#493))
([1d10c1c](testcontainers@1d10c1c))
* Fix the return type of `DockerContainer.get_logs`
([testcontainers#487](testcontainers#487))
([cd72f68](testcontainers@cd72f68))
* **keycloak:** tests on aarch64, use image from [jboss -&gt; quay],
change supported version [16+ -> 18+]
([testcontainers#480](testcontainers#480))
([5758310](testcontainers@5758310))
* **postgres:** doctest
([testcontainers#473](testcontainers#473))
([c9c6f92](testcontainers@c9c6f92))
* read the docs build works again
([testcontainers#496](testcontainers#496))
([dfd1781](testcontainers@dfd1781))
* readthedocs build - take 1
([testcontainers#495](testcontainers#495))
([b3b9901](testcontainers@b3b9901))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tillahoffmann tillahoffmann tillahoffmann approved these changes

Assignees
No one assigned
Labels
📦 package: compose
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bitplane @alexanderankin @tillahoffmann