From 6f17878734116131e924bd674180381c92346e91 Mon Sep 17 00:00:00 2001 From: yakimka Date: Wed, 12 Jan 2022 15:01:32 +0200 Subject: [PATCH 1/4] Drop support for python 3.5 --- setup.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup.py b/setup.py index a0d840d49..4e38fee16 100644 --- a/setup.py +++ b/setup.py @@ -68,5 +68,5 @@ }, long_description_content_type="text/x-rst", long_description=long_description, - python_requires='>=3.5', + python_requires='>=3.6', ) From d737e97fc6a5bf529e34f003238495dd4e016378 Mon Sep 17 00:00:00 2001 From: yakimka Date: Sat, 26 Mar 2022 22:16:56 +0200 Subject: [PATCH 2/4] Add dirs exclude for flake8 --- setup.cfg | 1 + 1 file changed, 1 insertion(+) diff --git a/setup.cfg b/setup.cfg index 3b42fe85a..c82dc448f 100644 --- a/setup.cfg +++ b/setup.cfg @@ -13,3 +13,4 @@ description-file = README.md [flake8] max-line-length = 100 +exclude = .git,__pycache__,build,dist,venv,.venv From d06d1da86fca98fab48a393590303d16b4a13a55 Mon Sep 17 00:00:00 2001 From: "Taylor D. Edmiston" Date: Tue, 30 Nov 2021 15:47:18 -0500 Subject: [PATCH 3/4] Fix link syntax --- README.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.rst b/README.rst index 8df059e96..855d66249 100644 --- a/README.rst +++ b/README.rst @@ -59,7 +59,7 @@ Usage within Docker (i.e. in a CI) When trying to launch a testcontainer from within a Docker container two things have to be provided: -1. The container has to provide a docker client installation. Either use an image that has docker pre-installed (e.g. the [official docker images](https://hub.docker.com/_/docker)) or install the client from within the `Dockerfile` specification. +1. The container has to provide a docker client installation. Either use an image that has docker pre-installed (e.g. the `official docker images `_) or install the client from within the `Dockerfile` specification. 2. The container has to have access to the docker daemon which can be achieved by mounting `/var/run/docker.sock` or setting the `DOCKER_HOST` environment variable as part of your `docker run` command. From 6b5461955e196ee4a12b708fb6f9bef750d468ad Mon Sep 17 00:00:00 2001 From: Yuya Ebihara Date: Fri, 13 Aug 2021 16:29:40 +0900 Subject: [PATCH 4/4] Add missing _configure to OracleDbContainer Additionally, fix Oracle example. --- testcontainers/oracle.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/testcontainers/oracle.py b/testcontainers/oracle.py index ea4d0b3cc..883c36af7 100644 --- a/testcontainers/oracle.py +++ b/testcontainers/oracle.py @@ -9,7 +9,7 @@ class OracleDbContainer(DbContainer): ------- :: - with OracleDbContainer(): + with OracleDbContainer() as oracle: e = sqlalchemy.create_engine(oracle.get_connection_url()) result = e.execute("select 1 from dual") """ @@ -24,3 +24,6 @@ def get_connection_url(self): dialect="oracle", username="system", password="oracle", port=self.container_port, db_name="xe" ) + + def _configure(self): + pass