diff --git a/README.rst b/README.rst index 8df059e96..855d66249 100644 --- a/README.rst +++ b/README.rst @@ -59,7 +59,7 @@ Usage within Docker (i.e. in a CI) When trying to launch a testcontainer from within a Docker container two things have to be provided: -1. The container has to provide a docker client installation. Either use an image that has docker pre-installed (e.g. the [official docker images](https://hub.docker.com/_/docker)) or install the client from within the `Dockerfile` specification. +1. The container has to provide a docker client installation. Either use an image that has docker pre-installed (e.g. the `official docker images `_) or install the client from within the `Dockerfile` specification. 2. The container has to have access to the docker daemon which can be achieved by mounting `/var/run/docker.sock` or setting the `DOCKER_HOST` environment variable as part of your `docker run` command. diff --git a/setup.cfg b/setup.cfg index 3b42fe85a..c82dc448f 100644 --- a/setup.cfg +++ b/setup.cfg @@ -13,3 +13,4 @@ description-file = README.md [flake8] max-line-length = 100 +exclude = .git,__pycache__,build,dist,venv,.venv diff --git a/setup.py b/setup.py index 8d2b117b2..2f866d34d 100644 --- a/setup.py +++ b/setup.py @@ -70,5 +70,5 @@ }, long_description_content_type="text/x-rst", long_description=long_description, - python_requires='>=3.5', + python_requires='>=3.6', ) diff --git a/testcontainers/oracle.py b/testcontainers/oracle.py index ea4d0b3cc..883c36af7 100644 --- a/testcontainers/oracle.py +++ b/testcontainers/oracle.py @@ -9,7 +9,7 @@ class OracleDbContainer(DbContainer): ------- :: - with OracleDbContainer(): + with OracleDbContainer() as oracle: e = sqlalchemy.create_engine(oracle.get_connection_url()) result = e.execute("select 1 from dual") """ @@ -24,3 +24,6 @@ def get_connection_url(self): dialect="oracle", username="system", password="oracle", port=self.container_port, db_name="xe" ) + + def _configure(self): + pass