Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Prepend "library/" to official docker image "alpine" #6166

Closed
akurth opened this issue Nov 11, 2022 · 2 comments
Closed

[Enhancement]: Prepend "library/" to official docker image "alpine" #6166

akurth opened this issue Nov 11, 2022 · 2 comments

Comments

@akurth
Copy link

akurth commented Nov 11, 2022

Module

Core

Proposal

Hello,

would it be possible to prepend "library/" to the official alpine docker image pulled in ("library/alpine"); that’s where the image is actually located.

Reason: it is often desired to use a dockerhub mirror (because of rate limits), which we achieve by setting the following property: "hub.image.name.prefix=our.company.mirror/". While this works fine for the testcontainers images, it doesn’t work for the official docker images like "alpine". We have to work around that by setting the property "tinyimage.container.image=library/alpine:3.16", which is deprecated and discouraged according to the docs.

@eddumelendez
Copy link
Member

Closing as duplicated. See #5612

@eddumelendez eddumelendez closed this as not planned Won't fix, can't repro, duplicate, stale Nov 14, 2022
@akurth
Copy link
Author

akurth commented Nov 14, 2022

This case is a bit different than #5612.

It is perfectly fine for us to use the asCompatibleSubstituteFor workaround when instantiating e.g. postgres containers in our code. The "alpine" image is not actively used by ourselves though; it is implicitly used by the testcontainers framework. Since we don’t have control over this one, we have to use the deprecated property tinyimage.container.image.

@akurth akurth changed the title [Enhancement]: Prepend library/ to docker official images [Enhancement]: Prepend "library/" to official docker image "alpine" Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants