Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify configuration of registry #3430

Closed
markusa380 opened this issue Nov 2, 2020 · 3 comments
Closed

Simplify configuration of registry #3430

markusa380 opened this issue Nov 2, 2020 · 3 comments

Comments

@markusa380
Copy link

This issue is based on the changes regarding rate limiting of pulls from Docker hub.

This means that many projects are currently switching to their own image registries where the images required for e.g. CI are re-tagged and re-pushed to avoid requesting Docker hub.

Currently, some modules, like kafka for example, only allow providing the version of the image tag as parameter.
It's still possible to define a modified image using testcontainers.properties file, but this leads to it's own set of problems.

Take this example:

  • A project called my-kafka-test-library defines some utilities for setting up and testing with Kafka containers.
  • A project called my-pulsar-test-library defines some utilities for setting up and testing with Pulsar containers.
  • Two projects called my-service-1 and my-service-2 depend on these utilities for their tests.
  • The developer now wants to avoid hitting the rate limit.
    ** The dev cannot use testcontainers.properties in the two library projects as they will collide on the classpath.
    ** The dev should not define testcontainers.properties in the services projects as it causes coupling between the test library code and the configuration in the services.
    ** The dev should not use any hacks to change configuration at runtime

So it is clear that the best option is to provide the ability to pass the full image tag as a parameter.

@bsideup
Copy link
Member

bsideup commented Nov 2, 2020

see #3102

@rnorth
Copy link
Member

rnorth commented Nov 5, 2020

Yep, sorry we've not managed to ship all these changes before the rate limit's official start. The constructor allowing the full docker image name to be specified is published in 1.15.0-rc2 though.

We're working on 1.15.0, and hope to release very soon!

@eddumelendez
Copy link
Member

Closing this as resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants