Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NetworkImpl.NetworkImplBuilder should not allow to reassign id() #2185

Closed
leventov opened this issue Dec 16, 2019 · 4 comments
Closed

NetworkImpl.NetworkImplBuilder should not allow to reassign id() #2185

leventov opened this issue Dec 16, 2019 · 4 comments
Labels
good first issue help wanted

Comments

@leventov
Copy link

NetworkImpl.NetworkImplBuilder should not allow to reassign id() because it will have no effect on the actual id.

Also, strictly speaking, close() may not see the id value if called from another thread than getId(). To ensure that, close() method should be synchronized as well as getId(). I'm not sure how relevant this is, but since getId() is synchronized itself it might be.
@bsideup
Copy link
Member

bsideup commented Dec 16, 2019

Hi @leventov,

Thanks for reporting. The issue is up for grabs in case somebody wants to convert the suggestions into a PR.

@pivovarit pivovarit mentioned this issue Dec 21, 2019
Merged
@Mariochino
Copy link

#2450

@quincy
Copy link
Contributor

quincy commented May 28, 2020

I've submitted a PR to resolve this issue. #2807

@Nicklas2751
Copy link

This issue can be closed since #2807 is merged. Right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@quincy @leventov @bsideup @eddumelendez @Nicklas2751 @Mariochino