Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: TESTCONTAINERS_HUB_IMAGE_NAME_PREFIX trailing slash not handled properly #2746

Closed
driverpt opened this issue Aug 26, 2024 · 1 comment · Fixed by #2747
Closed

[Bug]: TESTCONTAINERS_HUB_IMAGE_NAME_PREFIX trailing slash not handled properly #2746

driverpt opened this issue Aug 26, 2024 · 1 comment · Fixed by #2747
Labels
bug An issue with the library

Comments

@driverpt
Copy link
Contributor

Testcontainers version

0.33.0

Using the latest Testcontainers version?

Yes

Host OS

MacOS

Host arch

x86

Go version

1.23

Docker version

Docker version 27.1.1, build 6312585

Docker info

N/A

What happened?

If we add a trailing slash to TESTCONTAINERS_HUB_IMAGE_NAME_PREFIX, which we do by convention, Test Containers doesn't handle this very well. All containers end up having something like i.e.:<custom_url>//<image> which causes it to fail.

Relevant log output

No response

Additional information

No response

@driverpt driverpt added the bug An issue with the library label Aug 26, 2024
@mdelapenya
Copy link
Member

Where does that message come from? 😱

@github-staff github-staff deleted a comment from driverpt Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue with the library
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants
@mdelapenya @driverpt and others