Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs/modules/compose.md page for compose module #1515

Open
mdelapenya opened this issue Aug 23, 2023 · 2 comments
Open

Add docs/modules/compose.md page for compose module #1515

mdelapenya opened this issue Aug 23, 2023 · 2 comments
Labels
compose Docker Compose. documentation Docs, docs, docs. hacktoberfest Pull Requests accepted for Hacktoberfest.

Comments

@mdelapenya
Copy link
Member

          > By the way, I noticed that there is no `docs/modules/compose.md` is it on purpose ?

Indeed, it's on purpose as we do have a separate page in https://golang.testcontainers.org/features/docker_compose/.

But I think it would be a good idea to add it to the modules and reduce the number of corner cases across code generation. I'll do it in a separate PR. Thanks for pointing this out!

Originally posted by @mdelapenya in #1504 (comment)

@mdelapenya mdelapenya added the documentation Docs, docs, docs. label Aug 23, 2023
@mdelapenya mdelapenya added the hacktoberfest Pull Requests accepted for Hacktoberfest. label Oct 11, 2023
@KianYang-Lee
Copy link

@mdelapenya are you working on this? Do you mind if I pick this up? thanks

@mdelapenya
Copy link
Member Author

Hey @KianYang-Lee , no, I'm not working on it, I'd appreciate if you can do it. Please let me know if you need anything from me. 🙇

@mdelapenya mdelapenya added the compose Docker Compose. label Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compose Docker Compose. documentation Docs, docs, docs. hacktoberfest Pull Requests accepted for Hacktoberfest.
Projects
None yet
Development

No branches or pull requests

2 participants