Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate TestcontainerLabelIsReaper variable, as there exists an internal one with the same key: testcontainersdocker.LabelReaper #1473

Closed
mdelapenya opened this issue Aug 9, 2023 · 1 comment
Closed

Deprecate TestcontainerLabelIsReaper variable, as there exists an internal one with the same key: testcontainersdocker.LabelReaper #1473

mdelapenya opened this issue Aug 9, 2023 · 1 comment
Labels
chore Changes that do not impact the existing functionality

Comments

@mdelapenya
Copy link
Member

mdelapenya commented Aug 9, 2023 •
edited
Loading

I think we should deprecate this TestcontainerLabelIsReaper variable, as there exists an internal one with the same key: testcontainersdocker.LabelReaper

Originally posted by @mdelapenya in #1339 (comment)
@mdelapenya mdelapenya added the chore Changes that do not impact the existing functionality label Aug 9, 2023
@mdelapenya
Copy link
Member Author

Closing, as it was done in #813

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore Changes that do not impact the existing functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mdelapenya