Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Improve ASP NET example with SQL Server using Rosetta #1204

Closed
mmalvik opened this issue Jun 25, 2024 · 2 comments · Fixed by #1245
Closed

[Enhancement]: Improve ASP NET example with SQL Server using Rosetta #1204

mmalvik opened this issue Jun 25, 2024 · 2 comments · Fixed by #1245
Labels
documentation Docs, docs, docs. enhancement New feature or request

Comments

@mmalvik
Copy link

mmalvik commented Jun 25, 2024

Problem

The docs say:

The Microsoft SQL Server Docker image is not compatible with ARM devices, such as Macs with Apple Silicon. Instead, you can use the [SqlEdge](https://www.nuget.org/packages/Testcontainers.SqlEdge) module or [Testcontainers Cloud](https://www.testcontainers.cloud/).

I think it would be smart to point out the SQL Server image can run fine on ARM Mac using Rosetta.
At least in using Docker desktop this works fine:

image

SQL Edge also has some downsides:

However, using Azure SQL Edge does have some drawbacks. First, you cannot develop against a specific SQL Server 2017/2019/2022 version with Azure SQL Edge. Second, SQL Edge’s unsupported features impose a limit on some scenarios, including: In-Memory OLTP, CLR, and CLR based data types.

Source: https://techcommunity.microsoft.com/t5/sql-server-blog/azure-sql-edge-update-september-2023/ba-p/3930827

Solution

Improve the example with info on how to run the SQL Server.

Another alternative is to remove those details from the example and move it to
https://dotnet.testcontainers.org/modules/mssql/

Benefit

Improved documentation.

Alternatives

Leave the docs as is.

Would you like to help contributing this enhancement?

Yes

@mmalvik mmalvik added the enhancement New feature or request label Jun 25, 2024
@HofmeisterAn
Copy link
Collaborator

Thanks for sharing the issue/enhancement. I totally forgot about the documentation. I replaced Azure SQL Edge with PostgreSQL some time ago (#1156) after Microsoft announced they would no longer continue developing or supporting it.

I suggest changing the documentation to indicate that the referenced example uses PostgreSQL. Then, add the information about Rosetta to the MSSQL module documentation. WDYT?

@HofmeisterAn HofmeisterAn added the documentation Docs, docs, docs. label Jun 25, 2024
@mmalvik
Copy link
Author

mmalvik commented Jun 25, 2024

That sounds good to me 👍

I can look into a PR for this soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Docs, docs, docs. enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants