Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish to GitHub Docker Registry #16

Closed
codefromthecrypt opened this issue Nov 6, 2020 · 4 comments
Closed

Publish to GitHub Docker Registry #16

codefromthecrypt opened this issue Nov 6, 2020 · 4 comments

Comments

@codefromthecrypt
Copy link

In zipkin, we'd like to reduce the risk of build outages for anyone running our build (ex ourselves, as well as people forking zipkin of which there are many). An easy way is to stop using docker hub registry during the build process. We've eliminated nearly all image pulls we can find, but I suspect ryuk is still implicitly pulling from docker hub. Can you publish this also to GitHub Container registry?

Note: So far, we've not found a mirror for alpine that supports arm64, so while publishing to github should be fine, you might have trouble with FROM. That said, consumers can still benefit even if this repo can't purely depend on GHCR.

@codefromthecrypt
Copy link
Author

Hi, this is particularly important or otherwise, could we get this reversed?

14:24:46,598 WARN  [main] utility.ConfigurationFileImageNameSubstitutor (ConfigurationFileImageNameSubstitutor.java:31) - Image name testcontainers/ryuk:0.3.0 was substituted by configuration to ghcr.io/openzipkin/testcontainers-ryuk:latest. This approach is deprecated and will be removed in the future

Another option would be to register formally as OSS with docker which subject to annual approval I believe allows consumers to not consume pulls every time. Probably easier, to just push to ghcr.io though

@bsideup
Copy link
Member

bsideup commented Nov 20, 2020

We applied for the rate limit exemption for http://hub.docker.com/r/testcontainers/ and it should be working now. Please let us know if you still see the rate limit errors for testcontainers/* images 👍

@bsideup bsideup closed this as completed Nov 20, 2020
@codefromthecrypt
Copy link
Author

applied and accepted I assume? zipkin is still not accepted, though applied. would be nice if they had an indicator like twitter's "verified accounts" for this

@bsideup
Copy link
Member

bsideup commented Nov 20, 2020

yes, they got back to us and confirmed that we "passed". Since then, I've seen some weird 404 errors, but no rate limit-related ones :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants