-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configuration option for user Vagrantfiles #112
Conversation
And I'm immediately questioning the usefulness of converting the paths from absolute back to relative... |
👍 |
@@ -1,3 +1,9 @@ | |||
<% config[:vagrantfiles].each do |vagrantfile| | |||
#REVIEW: should this check for file existance or fail? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sethvargo I wasn't sure if you had a reason for checking the file's existence in your example. My thought is that the user should be informed if their Vagrantfiles are missing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ummm, yea, you're probably right
@byggztryng Given a cookbook, with
I get this error when I try to
My
So, obviously I'm missing something, right? |
@gkra sorry for the delay. Could you try again with a non hidden Vagrantfile (remove the leading dot)? |
Same result.
|
@gkra okay, thanks. There's clearly a bug that's always resolving the path to be from /, which is strange because I did test this successfully. I'll have a look. |
@gkra feel free to give it a try now; I've updated the README with an explanation, too. |
Finally had a chance to test this, works for me exactly as I'd hoped. 👍 |
@gkra Excellent, thanks! |
Any consideration on merging this? It seems like it would solve #97. |
Add configuration option for user Vagrantfiles
Merged in b4ee172. Thanks! |
This adds a config option, 'vagrantfiles', that takes an arbitrary list of relative or absolute paths to Vagrantfiles and merges them with the generated Vagrantfile.
Internally, the list of Vagrantfile paths is converted to absolute paths and then to paths relative to the generated Vagrantfile.