-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We can running the test without using ssh #96
Comments
Kitchen is using Docker as an API to/for Linux containers, I do not see this as an anti-pattern. Many cookbooks are installing/configuring a collection of services, managing machines. Using SSH supports the common TK experience, |
Using SSH on Kitchen that is not anti-pattern. I think so too. Please say me if you need cooperation when you see my usage 😄 |
@portertech where I would see the main benefit for this, is when I'm testing cookbooks/manifests that start upstart services. SSH does not work as a valid replacement for Upstart, and using docker images that enable upstart won't work via the current SSH experience. I think we are operating at a rare use-case for docker images, and attempting to use them as lightweight VM's inside test-kitchen. Some of our test roles require starting multiple upstart jobs. Like, Sensu for instance. It is currently impossible to test our convergence of our sensu role, as the sensu service depends on Upstart running in order to start. Unless we are doing something wrong in our CI pipeline, or we want to run our CI Test Slave on a bare metal server, we will need to run TK tests from a docker or lxc driver in our cloud provider. |
Offering only SSH access can be a problem. As an example, consider test-kitchen suites running with docker on CircleCI, which offers its docker interface through an encrypted URL that changes with each environment setup. In this environment kitchen fails everytime because it can't connect to the SSH socket of the test container. Using the native |
This is planned for the future, though for context |
Any update on this? |
@hurricanehrndz Nope, other than that you should check out |
Going to close this since while it is on my long-term roadmap, it's not in any specific planning. |
Hey, just wanted to know if this is on the roadmap nowadays ? Using SSH testing over docker feels unclean, and it's enforcing some weird stuff. For example I had to remove systemd ssh service file to rely on sysV init script otherwise kitchen couldn't login, whenever I've to test systemd services ---
driver:
name: docker
use_sudo: false
provision_command:
- rm /lib/systemd/system/ssh.service
run_command: /bin/systemd
privileged: true
volume:
- "/sys/fs/cgroup:/sys/fs/cgroup:ro" Meanwhile on verifier side, I just don't use SSH at all because docker backend is native for testinfra verifier:
name: shell
remote_exec: false
command: pytest --junitxml=test/${KITCHEN_INSTANCE}_test_report.xml --html=test/${KITCHEN_INSTANCE}_test_report.html --self-contained-html --color=yes --host="docker://root@${KITCHEN_CONTAINER_ID}" "test/integration/" On my user side, I feel like I just miss a |
@rgarrigue kitchen-docker no longer has a roadmap, no further development is planned. |
Okay. So what's the recommandation? Dokken ? |
Thank you for new version release the other day.
We had better not use ssh on Docker container.
See also http://jpetazzo.github.io/2014/06/23/docker-ssh-considered-evil/
And we have some issues like #40 #81
So, I have an idea to solve them.
And the idea has been implemented on this driver plugin that made from scratch.
https://github.com/marcy-terui/kitchen-docker_cli
I started to make the plugin because it was thought to have stopped development.
But, the mainstream of kitchen-docker has resumed development.
And I have welcome it.
@portertech
If you want, I 'm going to make and send some PRs.
But, they become big changes.
Therefore, there are some possibilities that become unstable.
So, I want to hear what you think.
The text was updated successfully, but these errors were encountered: