Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Varnish cacheable requests #351

Closed
Snowman7785 opened this issue Dec 23, 2014 · 3 comments
Closed

Varnish cacheable requests #351

Snowman7785 opened this issue Dec 23, 2014 · 3 comments
Milestone

Comments

@Snowman7785
Copy link

We have varnish in front of our Graphite's web server as we are trying to keep the impact to the server low. A lot of the render requests end in jsonp=jQuery_= which causes the requests to bypass the cache. I did some testing and was pulling the same data whether the numbers were appended or not. Here's an example call:

Request URL:http://<graphite_url>//render?format=json&from=-1h&tz=Etc%2FUTC&target=&jsonp=jQuery1110006516687339171767_1419377088900&_=1419377088901

Are these necessary for something? Is there a way to disable this? Maybe make it a configuration option?

Regards,
Brandon

@aalpern
Copy link
Member

aalpern commented Jan 13, 2015

@MO-BrandonR This is an artifact of the jsonp format support in jQuery used for handling graphite authentication. I'll see about disabling it when auth is not needed, and whether it's really necessary or not when using auth. Sorry for the delay! Not much happened over the holidays :)

@Snowman7785
Copy link
Author

No worries. Thanks for the update and the awesome dashboard!

aalpern added a commit that referenced this issue Jun 2, 2015
@aalpern aalpern added this to the Release 0.9 milestone Dec 7, 2016
@aalpern
Copy link
Member

aalpern commented Dec 8, 2016

After the switch to axios for making graphite requests (aalpern@f588d69), this should no longer be an issue.

@aalpern aalpern closed this as completed Dec 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants