Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Norwegian translation #496

Closed
spacecosmos opened this issue Mar 4, 2020 · 5 comments
Closed

Add Norwegian translation #496

spacecosmos opened this issue Mar 4, 2020 · 5 comments
Labels
kind:idea Idea for new feature or some form of enhancement

Comments

@spacecosmos
Copy link
Contributor

spacecosmos commented Mar 4, 2020

I want to add a Norwegian translation. But my skills with GitHub is rather poor, unfortunately.

I can see the PO files under here:
teslamate/priv/gettext

How exactly can I add it? Pull request and then add the file? Any guidance would be greatly appreciated.

@spacecosmos spacecosmos added the kind:idea Idea for new feature or some form of enhancement label Mar 4, 2020
@tabascoeye
Copy link

tabascoeye commented Mar 4, 2020

Normally you
1."fork" the repository so that you have a clone in your own repos
2.add/change/delete whatever you want in that fork
3.create a Pull-request from your fork and hope for the best

@rfvgyhn
Copy link

rfvgyhn commented Mar 4, 2020

If you're unfamiliar with git and not just github, you can also do it directly from your browser.

  1. Navigate to priv/gettext and click the Create new file button
  2. Set the file name to no/LC_MESSAGES/default.po (assuming no is the correct language code)
  3. Copy and paste the contents of priv/gettext/default.pot into the text area and make your edits. Make sure to add the correct header lines like in existing translation files.
  4. Add a commit message saying what you added and click the Propose new file button

@spacecosmos
Copy link
Contributor Author

spacecosmos commented Mar 5, 2020

Thank you for your help guys. Not sure if I've done it correctly, but I managed to put inn two pull request: #499 and #500

I tried to follow @rfvgyhn guide above.

Let me know if there is something else I need to do. (@adriankumpf)

@tabascoeye
Copy link

4\. Add a commit message saying what you added and click the _Propose new file_ button

whoa. I didn't know that works. Cool

@adriankumpf
Copy link
Collaborator

Merged into master. Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:idea Idea for new feature or some form of enhancement
Projects
None yet
Development

No branches or pull requests

4 participants