Fix plugin-js object keys, sort tokens #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bcd149e The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
drwpow
commented
Aug 31, 2023
| @@ -14,14 +14,14 @@ export const tokens = { | |||
|
|
|||
| export const meta = { | |||
| border: { | |||
| '_original': { | |||
| '$type': 'border', | |||
There was a problem hiding this comment.
This is now cleaner—these didn’t need quotes
Deploying with
|
| Latest commit: |
bcd149e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e302ebb0.cobalt-ui.pages.dev |
| Branch Preview URL: | https://fix-91.cobalt-ui.pages.dev |
drwpow
changed the title
drwpow
commented
Aug 31, 2023
| 80: ParsedColorToken; | ||
| 90: ParsedColorToken; | ||
| 100: ParsedColorToken; | ||
| '10': ParsedColorToken; |
There was a problem hiding this comment.
Now numbers get quoted. This shouldn’t be a breaking change; just errs on the side of safety (esp. with zero-padded numbers like 00)
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #91. JS-valid keys weren’t being properly sniffed out, which led to invalid code generation.
Also sorts token keys so they will appear in a more predictable order.
How to Review