Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow arrows of shadows #88

Closed
snicol21 opened this issue Aug 27, 2023 · 2 comments · Fixed by #114
Closed

Allow arrows of shadows #88

snicol21 opened this issue Aug 27, 2023 · 2 comments · Fixed by #114
Labels
enhancement New feature or request

Comments

@snicol21
Copy link

@drwpow i definitely agree with your recommendation you made here to support multiple shadows, my specific use case is leveraging designs from Material UI, whose shadow tokens are an array of 3 shadows

"0px 2px 1px -1px rgba(0,0,0,0.2),
0px 1px 1px 0px rgba(0,0,0,0.14),
0px 1px 3px 0px rgba(0,0,0,0.12)"

It sounds like you were considering expanding your tool to allow arrays, is that still the case?

@snicol21
Copy link
Author

Which it also appears that your spec matches the community spec (as it should), but is also missing "inset" from the shadow objects as also mentioned on this same shadow feedback

@drwpow
Copy link
Collaborator

drwpow commented Aug 31, 2023

Which it also appears that your spec matches the community spec (as it should), but is also missing "inset" from the shadow objects as also mentioned on this same shadow feedback

Ah that’s a good callout—this should definitely support the inset property. 👍

It sounds like you were considering expanding your tool to allow arrays, is that still the case?

Checking back on that thread, most of the authors seemed open to the idea of supporting an array of shadows, so I don’t see why not 🙂. But I think it should probably be limited to the shadow type specifically, to avoid opening a can of worms with other types (while an array of shadows has a clear application—layer them—the case is not so with many other types)

@drwpow drwpow added the enhancement New feature or request label Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants