Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grid container with shape circle doesn't position cells correctly #1733

Closed
gavin-ts opened this issue Nov 15, 2023 · 0 comments · Fixed by #1734
Closed

grid container with shape circle doesn't position cells correctly #1733

gavin-ts opened this issue Nov 15, 2023 · 0 comments · Fixed by #1734
Assignees
Labels
bug Something isn't working layout

Comments

@gavin-ts
Copy link
Contributor

gavin-ts commented Nov 15, 2023

for grid containers that have a shape: squares and circles should maintain their aspect ratio and fit contents inside each shape's inner box.

Previously shape's were fit to content without label/icon, and now they are fit including the label/icon after #1731, but the positioning isn't always correct particularly with shape: circle

Note that this is for grid containers specifically ( dagre doesn't have this feature, only constant padding but #1648 might be able to help)

older playground version

Screenshot 2023-11-15 at 2 31 57 PM

current

Screenshot 2023-11-15 at 2 32 40 PM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working layout
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant