fix builds on 32bit #1115
Merged
fix builds on 32bit #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vaelatern
force-pushed
the
fix-32-bit-again
branch
from
857b9e3
to
36d2bd0
Compare
alixander
approved these changes
Mar 30, 2023
There was a problem hiding this comment.
oh interesting. i wonder if there's an easy automated test we can do to make sure this doesn't regress.
@nhooyr should we include a GOARCH=386 build in the CI? (i think that's what cross compiles to 32-bit: https://go.dev/doc/install/source#environment)
|
@alixander that would work. I opened #1121 |
|
great. @Vaelatern can you please attach a changelog line that this was a bug fixed? thanks again https://github.com/terrastruct/d2/blob/master/ci/release/changelogs/next.md |
If you put the uint32 type at the top instead of later, 32 bit builds All credit @ahesford
Vaelatern
force-pushed
the
fix-32-bit-again
branch
from
36d2bd0
to
3228ae4
Compare
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you put the uint32 type at the top instead of later, 32 bit builds
All credit @ahesford