-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dealing with sun/shade in stereo image #326
Comments
@ZongyangLi what an improvement! |
How robust is it? What happens when there are no shaded pixels?
…On Thu, Jun 8, 2017 at 10:22 AM Max Burnette ***@***.***> wrote:
@ZongyangLi <https://github.com/zongyangli> what an improvement!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#326 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAcX51m79ezBI5vV9mfqIusmPm41x670ks5sCBG9gaJpZM4NtRaa>
.
|
More test should be done to see whether it is robust enough. If there are no shaded pixels, it will choose a darker pixel in the tiles set. |
@ZongyangLi can you share sunshade code? |
@ZongyangLi I think you also need to upload an imported file:
...don't think this file was included unless it was renamed. do we want to do this as 2 separate extractors? @ZongyangLi suggests we may not always want to use darker pixels so we may want to preserve the original version as well and might want to retain old version + this version I wonder if we can do this using parameters. |
@pless can you please review / comment on / approve or suggest further changes to the updated algorithm? |
I think the current algorithm is appropriate for making a stitched whole field image for quality assurance and some simple processing. I'm not sure that any simple stitching process (or any more complicated process that would be called stitching) is good enough to be used for more complicated analysis. |
I'm not clear - what is the current stitched image suitable for and what is
it not suitable for? What is the alternative?
…On Tue, Jul 11, 2017 at 5:42 PM Robert Pless ***@***.***> wrote:
I think the current algorithm is appropriate for making a stitched whole
field image for quality assurance and some simple processing. I'm not sure
that any simple stitching process (or any more complicated process that
would be called stitching) is good enough to be used for more complicated
analysis.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#326 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAcX520nnA2Z8pnjdQlfA90aCkCuY0Gjks5sM_pYgaJpZM4NtRaa>
.
|
I think the current stitched image is suitable for most data quality and coverage assessments and some data analysis. For data quality, the stitched image, as is, is good for:
For data analysis, the stitched image, as is, is good for:
For some data analysis, the stitched image will cause some problems. To ground this discussion, here is an example of a stitched image
The alternative is to always to all initial feature selection or image analysis on the original images, and to then create derived features or extracted features from those images and save those derived or extracted features per plot. |
@pless thank you for the description. Regarding the alternative you suggest 'always do all initial feature selection or image analysis on the original images', what do we need to do to support algorithms that use the original images? Should we support both the current (stitch-->clip-->analyze) approach as well as the alternative (clip-->analyze-->combine)? For the clip-->analyze-->combine approach, should we organize by plot e.g. in a directory named sensor/date/plot? Is there a general way to combine results (e.g. weighting by area covered and accounting for resampling of the same area due to image overlap ?). |
We are planning to deal with sun/shade in full field stitched rgb image by choosing a darker tile in a set of tiles, since we have overlap images.
If above method do not work well, we may try a variant of high-dynamic range rendering, this is not the best choice because the data is missing.
The text was updated successfully, but these errors were encountered: