Database load has a hidden exception

[john-science]

A bare except with a pass inside is always a bit troublesome, but this is an important piece of code:

armi/armi/bookkeeping/db/database.py

Lines 412 to 424 in 85053e3

	try:
	cs.loadFromString(
	self.h5db["inputs/settings"].asstr()[()], handleInvalids=handleInvalids
	)
	except KeyError:
	# not all paths to writing a database require inputs to be written to the
	# database. Technically, settings do affect some of the behavior of database
	# reading, so not having the settings that made the reactor that went into
	# the database is not ideal. However, this isn't the right place to crash
	# into it. Ideally, there would be not way to not have the settings in the
	# database (force writing in writeToDB), or to make reading invariant to
	# settings.
	pass

According to Nick below, the original reasons for this are no longer relevant. So I recommend removing this (and testing to make sure everything still works).

[ntouran]

I think it's from a transition time when we first started writing inputs to the databases. We wanted it to still work if the inputs weren't in there but also work if the inputs were in there. This is obviously not a good solution, and it's probably not a meaningful issue anymore unless we want to dig up old results. You can probably just remove the try/except safely here.

[john-science]

Thanks, Nick!