Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor dead link on CONTRIBUTE.md #497

Open
tshefi opened this issue Jan 9, 2024 · 1 comment
Open

Minor dead link on CONTRIBUTE.md #497

tshefi opened this issue Jan 9, 2024 · 1 comment

Comments

@tshefi
Copy link
Contributor

tshefi commented Jan 9, 2024

Under step 4. Manual testing and debugging There is a link titled "here en example for that"

The dead link is: https://github.com/terraform-redhat/terraform-rhcs-rosa/tree/main/examples/rosa-classic-with-unmanaged-oidc

Should it be changed to this one instead?
https://github.com/terraform-redhat/terraform-provider-rhcs/tree/main/examples/create_rosa_sts_cluster/oidc_configuration/cluster_with_unmanaged_oidc_config (notice this is STS cluster not classic as the original dead link)

@nirarg
Copy link
Member

nirarg commented Jan 11, 2024

Thank you @tshefi
You right, the directory name was changed there

Should it be changed to this one instead?
https://github.com/terraform-redhat/terraform-provider-rhcs/tree/main/examples/create_rosa_sts_cluster/oidc_configuration/cluster_with_unmanaged_oidc_config (notice this is STS cluster not classic as the original dead link)

No, this is not the example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants