Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow resizing of virtual disks #2244

Merged
merged 2 commits into from
Aug 9, 2024
Merged

feat: allow resizing of virtual disks #2244

merged 2 commits into from
Aug 9, 2024

Conversation

spacegospod
Copy link
Collaborator

@spacegospod spacegospod commented Aug 9, 2024

Description

Increasing the size of a disk will no longer recreate it but modify it in-place.

Reductions in size are not supported by vCenter and will not be allowed.

The rest of the properties for r/virtual_disk are still marked with ForceNew and will continue to recreate the disk when changed.

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Added a new test case for this scenario.

Release Note

r/virtual_disk: Allow resizing of virtual disks

References

Closes #851

Signed-off-by: Stoyan Zhelyazkov <[email protected]>
@spacegospod spacegospod self-assigned this Aug 9, 2024
@spacegospod spacegospod requested a review from a team as a code owner August 9, 2024 07:35
@github-actions github-actions bot added documentation Type: Documentation provider Type: Provider needs-review Status: Pull Request Needs Review labels Aug 9, 2024
@spacegospod spacegospod changed the title Allow resizing of virtual disks feat: allow resizing of virtual disks Aug 9, 2024
@tenthirtyam tenthirtyam added this to the v2.8.3 milestone Aug 9, 2024
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice addition for a long-time enhancement need!

@tenthirtyam tenthirtyam merged commit 45fc773 into main Aug 9, 2024
9 checks passed
@tenthirtyam tenthirtyam deleted the bugfix/resize-disk branch August 9, 2024 17:08
@tenthirtyam tenthirtyam removed the needs-review Status: Pull Request Needs Review label Aug 14, 2024
Copy link

This functionality has been released in v2.8.3 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Type: Documentation provider Type: Provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support to resize r/vsphere_virtual_disk
3 participants