chore(deps): bump github.com/vmware/govmomi from 0.29.0 to 0.30.4

[dependabot]

Bumps github.com/vmware/govmomi from 0.29.0 to 0.30.4.

Release notes

Sourced from github.com/vmware/govmomi's releases.

v0.30.4

Release v0.30.4

Release Date: 2023-03-16

💫 API Changes

• [23a6824e] support find.Network by cluster path
• [f4f6a5a7] support find.NetworkList by ID (#2626)

💫 govc (CLI)

• [52328902] Add feature VM IOMMU enablement support (#3055)

🧹 Chore

• [4561966a] Update version.go for v0.30.4

⚠️ BREAKING

📖 Commits

• [4561966a] chore: Update version.go for v0.30.4
• [52328902] govc: Add feature VM IOMMU enablement support (#3055)
• [23a6824e] api: support find.Network by cluster path
• [f4f6a5a7] api: support find.NetworkList by ID (#2626)

v0.30.2

Release v0.30.2

Release Date: 2023-02-01

🐞 Fix

• [4136fd8e] Pin the result limit of ssoadmin client to its MAX (#3004)

💫 vcsim (Simulator)

• [997d9ddc] add guest.net.ipConfig

🧹 Chore

• [9078b0b4] Update version.go for v0.30.2

⚠️ BREAKING

... (truncated)

Changelog

Sourced from github.com/vmware/govmomi's changelog.

Release v0.30.0

Release Date: 2022-12-12

🐞 Fix

• [1ad33d48] Heal the broken Namespace API
• [22c48147] Update $mktemp to support macOS
• [05b0b08c] DialTLSContext / Go 1.18+ CertificateVerify support

💫 API Changes

• [58f4112b] Update types to vSphere 8.0 GA
• [ba206c5b] add Content Library security compliance support
• [4c24f821] Add SRIOV device names
• [642156dd] Adds vSphere 7.0u1-u3 support to namespace-management (Tanzu)

💫 govc (CLI)

• [60a18c56] about.cert was not respecting -k
• [15d1181d] bash completion improvements
• [0dbf717b] Add sso.lpp.info and sso.lpp.update commands
• [fe87cff9] host.info: use writer instead of os.stdout
• [a7196e41] host.info: use writer instead of os.stdout
• [3d6de9da] fix host.esxcli runtime error occurred when no arguments specified
• [8c7ba5ef] Add feature in sso.group.ls to list groups using FindGroupsInGroup method
• [dc3e1d79] Add feature sso.group.lsgroups using FindGroupsInGroup method
• [bf991e6e] add event key for json and plain text output
• [2017e846] Support creating content libraries with security policies

💫 vcsim (Simulator)

• [86f9d42a] Update test keys to be RSA 2048
• [cedf695b] Fix duplicated name check in CloneVM_Task
• [8f4da558] add QueryNetworkHint support for LLDP and CDP details
• [1cab3254] Fix RetrieveProperties path validation to avoid panic
• [7f42a1d2] use node id for ServiceContent.InstanceUuid
• [03319493] Fix snapshot tasks to update rootSnapshot
• [b6ebcb6b] Fix disk capacity validation in ConfigureDevices
• [61032a23] Fix StorageIOAllocationInfo of VirtualDisk
• [cbfe0c93] support disconnect/reconnect host
• [b44828a4] Fix datastore freespace changed by ReconfigVM_Task

📃 Documentation

• [813a5d88] update README.md

🧹 Chore

... (truncated)

Commits

• 4561966 chore: Update version.go for v0.30.4
• 5232890 govc: Add feature VM IOMMU enablement support
• 23a6824 api: support find.Network by cluster path
• f4f6a5a api: support find.NetworkList by ID
• 0d36cdc chore: Update version.go for v0.30.3
• 9078b0b chore: Update version.go for v0.30.2
• 997d9dd vcsim: add guest.net.ipConfig
• 4136fd8 fix: Pin the result limit of ssoadmin client to its MAX
• 76a194e chore: Update version.go for v0.30.1
• 5818061 build(deps): bump goreleaser/goreleaser-action from 3 to 4
• Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

[appilon]

Using TestAccResourceVSphereVirtualMachine_basic as a smoketest is revealing a regression when upgrading to govmomi v0.30.X (I tried v0.30.0). It may be a non issue, it does seem like whatever datastore thats being cleaned up post test is in fact deleted, maybe just doing some odd double call or something, or maybe the response code has changed (error handling in Golang can be notoriously sloppy), but unfortunately I will have to put the upgrade through a thorough round of testing, this will take a significant amount of time until the CI work is complete (maybe we even just hold off until then).

=== RUN   TestAccResourceVSphereVirtualMachine_basic
    resource_vsphere_virtual_machine_test.go:41: Step 1/2 error: Error running apply: exit status 1

        Error: error mounting datastore: host "10.67.149.19": ServerFaultCode: An error occurred during host configuration.

          with vsphere_nas_datastore.ds1,
          on terraform_plugin_test.tf line 30, in resource "vsphere_nas_datastore" "ds1":
          30: resource "vsphere_nas_datastore" "ds1" {

    testing_new.go:82: Error running post-test destroy, there may be dangling resources: exit status 1

        Error: error unmounting hosts: host "10.67.149.19": ServerFaultCode: The object 'vim.Datastore:datastore-2097' has already been deleted or has not been completely created

--- FAIL: TestAccResourceVSphereVirtualMachine_basic (25.58s)

[appilon]

Okay well... I doubt I'll ever get an explanation why, but the test only fails when testing from this branch, when I update govmomi on main, dump my local testcase/modcache/everything cache, v0.30.4 passes. I'm going to chalk it up to some insane local testing/weird git related?? bug. I will merge main and see if my main branch passes locally.

[appilon]

🤷‍♂️ passes on main

[appilon]

approve

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.