Add Azure data source that can validate new creds #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
kalafut
reviewed
Mar 25, 2020
kalafut
reviewed
Mar 25, 2020
kalafut
reviewed
Mar 25, 2020
kalafut
reviewed
Mar 25, 2020
kalafut
reviewed
Mar 25, 2020
kalafut
reviewed
Mar 25, 2020
kalafut
reviewed
Mar 25, 2020
kalafut
reviewed
Mar 25, 2020
kalafut
reviewed
Mar 26, 2020
dandandy
pushed a commit
to dandandy/terraform-provider-vault
that referenced
this pull request
Jun 17, 2021
* add retrying azure data source * Update website/docs/d/azure_access_credentials.html.md Co-Authored-By: Jim Kalafut <[email protected]> * make comment more succinct * update var name, nix unused data * configure client without env vars * fix parameter description * add negative test * support environment, pull vars from config Co-authored-by: Jim Kalafut <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #580
This PR adds a data source for Azure that returns a client ID and secret. By default, these are just returned without testing whether they've fully propagated throughout Azure, which causes Terraform scripts to run quickly. However, by adding the information needed to validate credentials, it defaults to a retrying loop that one of our colleagues has found successful in the past. This retrying loop won't be appropriate for all environments and use cases, so every element of the loop is configurable.
Release note for CHANGELOG:
Output from acceptance testing: