Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support not_before_duration property in pki_secret_backend_role #698

Merged
merged 3 commits into from
Mar 7, 2020
Merged

Support not_before_duration property in pki_secret_backend_role #698

merged 3 commits into from
Mar 7, 2020

Conversation

shwuandwing
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

TESTARGS="--run TestPkiSecretBackendRole_basic" make testacc
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v --run TestPkiSecretBackendRole_basic -timeout 120m
?       github.com/terraform-providers/terraform-provider-vault [no test files]
?       github.com/terraform-providers/terraform-provider-vault/cmd/coverage    [no test files]
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-vault/util    (cached) [no tests to run]
=== RUN   TestPkiSecretBackendRole_basic
--- PASS: TestPkiSecretBackendRole_basic (0.27s)
PASS
ok      github.com/terraform-providers/terraform-provider-vault/vault   0.282s

@tyrannosaurus-becks tyrannosaurus-becks self-assigned this Mar 3, 2020
tyrannosaurus-becks
tyrannosaurus-becks reviewed Mar 3, 2020
View reviewed changes
Copy link
Contributor

@tyrannosaurus-becks tyrannosaurus-becks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Just need to let Vault do the defaulting and we'll be ready to merge. Thank you!

vault/resource_pki_secret_backend_role.go Outdated Show resolved Hide resolved
tyrannosaurus-becks
tyrannosaurus-becks approved these changes Mar 7, 2020
View reviewed changes
Copy link
Contributor

@tyrannosaurus-becks tyrannosaurus-becks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic. Thank you for contributing this. :-)

@tyrannosaurus-becks tyrannosaurus-becks merged commit 41b32d1 into hashicorp:master Mar 7, 2020
dandandy pushed a commit to dandandy/terraform-provider-vault that referenced this pull request Jun 17, 2021
@shwuandwing
Support not_before_duration property in pki_secret_backend_role (hash…
7665d06 
…icorp#698)

* Support not_before_duration property in pki_secret_backend_role

* Add default value for not_before_duration

* Properly Vault set the default if it is not set via terraform
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyrannosaurus-becks tyrannosaurus-becks tyrannosaurus-becks approved these changes

Assignees

@tyrannosaurus-becks tyrannosaurus-becks

Labels
documentation size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shwuandwing @tyrannosaurus-becks