Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_secret_backend: credentials are optional #634

Merged
merged 2 commits into from
Dec 19, 2019

Conversation

adongy
Copy link
Contributor

@adongy adongy commented Dec 13, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Close #633

Release note for CHANGELOG:

aws_secret_backend: support environment, shared and remote credentials

@ghost ghost added the size/XS label Dec 13, 2019
@ghost ghost added size/S documentation and removed size/XS labels Dec 13, 2019
@tyrannosaurus-becks tyrannosaurus-becks self-assigned this Dec 19, 2019
@tyrannosaurus-becks
Copy link
Contributor

Hi @adongy , thanks for working on this!

Question, would you be willing to run the new test and post its output as passing? I notice it's getting skipped by the automated tests.

=== RUN   TestAccAWSSecretBackend_basic
--- SKIP: TestAccAWSSecretBackend_basic (0.00s)
    provider_test.go:74: AWS_ACCESS_KEY_ID not set

@adongy
Copy link
Contributor Author

adongy commented Dec 19, 2019

Hey @tyrannosaurus-becks ,

Here it is:

make testacc TESTARGS='-run=TestAccAWSSecretBackend_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run=TestAccAWSSecretBackend_basic -timeout 120m
?   	github.com/terraform-providers/terraform-provider-vault	[no test files]
?   	github.com/terraform-providers/terraform-provider-vault/cmd/coverage	[no test files]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-vault/util	(cached) [no tests to run]
=== RUN   TestAccAWSSecretBackend_basic
--- PASS: TestAccAWSSecretBackend_basic (0.30s)
PASS
ok  	github.com/terraform-providers/terraform-provider-vault/vault	0.317s

Copy link
Contributor

@tyrannosaurus-becks tyrannosaurus-becks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This is awesome, much appreciated.

@tyrannosaurus-becks tyrannosaurus-becks merged commit 854b02f into hashicorp:master Dec 19, 2019
@adongy adongy deleted the adong/aws_secret_backend branch December 20, 2019 10:03
dandandy pushed a commit to dandandy/terraform-provider-vault that referenced this pull request Jun 17, 2021
aws_secret_backend: credentials are optional
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vault_aws_secret_backend requires AWS keys while they are not
2 participants