Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Vault 1.2+ token fields to LDAP auth #553

Merged
merged 1 commit into from
Sep 30, 2019
Merged

Add support for Vault 1.2+ token fields to LDAP auth #553

merged 1 commit into from
Sep 30, 2019

Conversation

kalafut
Copy link
Contributor

@kalafut kalafut commented Sep 27, 2019

No description provided.

catsby
catsby approved these changes Sep 30, 2019
View reviewed changes
Copy link
Contributor

@catsby catsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question about the upgrade experience here. If possible we want to avoid unexpected diffs in plans, so if there's a possibility here we need to take care and add a migration if possible/needed. Other than that, LGTM

vault/resource_ldap_auth_backend.go Show resolved Hide resolved
@kalafut kalafut merged commit ae306ad into master Sep 30, 2019
@kalafut kalafut deleted the ldap-token-fields branch September 30, 2019 20:45
dandandy pushed a commit to dandandy/terraform-provider-vault that referenced this pull request Jun 17, 2021
Add support for Vault 1.2+ token fields to LDAP auth (hashicorp#553)
d5f2284
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catsby catsby catsby approved these changes

@tyrannosaurus-becks tyrannosaurus-becks Awaiting requested review from tyrannosaurus-becks

Assignees
No one assigned
Labels
documentation size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kalafut @catsby