Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add root_rotation_statements to vault_database_secret_backend_connection #530

Merged
merged 2 commits into from
Oct 9, 2019

Conversation

hamishforbes
Copy link
Contributor

Fixes #527

@ghost ghost added the size/S label Sep 5, 2019
@tyrannosaurus-becks tyrannosaurus-becks self-assigned this Sep 6, 2019
Copy link
Contributor

@tyrannosaurus-becks tyrannosaurus-becks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for working on this, it's much appreciated! Per the contributing doc, it just needs one more thing, a related docs update, then it'll be good to go!

@ghost ghost added the documentation label Sep 9, 2019
@hamishforbes
Copy link
Contributor Author

Sure, added!

Copy link
Contributor

@tyrannosaurus-becks tyrannosaurus-becks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! Thank you!

@tyrannosaurus-becks tyrannosaurus-becks merged commit 38aeeaa into hashicorp:master Oct 9, 2019
dandandy pushed a commit to dandandy/terraform-provider-vault that referenced this pull request Jun 17, 2021
Add root_rotation_statements to vault_database_secret_backend_connection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support root_rotation_statements attribute
2 participants