Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Azure Secret Backend resource #481

Merged

Conversation

petems
Copy link
Contributor

@petems petems commented Aug 2, 2019

First of the two! (See #460)

@petems petems force-pushed the add_vault_azure_secret_backend branch 2 times, most recently from c7dca36 to 529aa97 Compare August 2, 2019 20:35
@tyrannosaurus-becks tyrannosaurus-becks self-assigned this Aug 2, 2019
Copy link
Contributor

@tyrannosaurus-becks tyrannosaurus-becks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very good! Just a couple of questions. Also, one more request, would you be willing to merge in master and push it up just to see the tests passing?

Thanks again!

vault/provider.go Outdated Show resolved Hide resolved
vault/resource_azure_secret_backend.go Show resolved Hide resolved
vault/resource_azure_secret_backend.go Show resolved Hide resolved
@petems petems force-pushed the add_vault_azure_secret_backend branch from 2fd0247 to 0b41011 Compare August 5, 2019 17:30
Copy link
Contributor

@tyrannosaurus-becks tyrannosaurus-becks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superb! Thank you!

@tyrannosaurus-becks tyrannosaurus-becks merged commit 1eb2db0 into hashicorp:master Aug 5, 2019
@petems petems deleted the add_vault_azure_secret_backend branch August 5, 2019 17:53
dandandy pushed a commit to dandandy/terraform-provider-vault that referenced this pull request Jun 17, 2021
…ackend

Add Azure Secret Backend resource
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants