-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update various Authentication Resources for Vault 1.2 #478
Update various Authentication Resources for Vault 1.2 #478
Conversation
19765cd
to
b2605cc
Compare
- Except Importing See hashicorp/vault#7020 Add deprecated tests - Remove behaviour for Pre-Vault 0.10
Fix tests
Update Github resources
Add tests Bump test images back to `latest`
3fe0de4
to
e8e3bff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow. Thank you, this is very much appreciated and quite excellent. Well done.
@@ -9,7 +9,7 @@ import ( | |||
"os" | |||
"sort" | |||
|
|||
"github.com/hashicorp/vault/logical/framework" | |||
"github.com/hashicorp/vault/sdk/framework" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch! Thank you!
I will submit a new pr to update the documentation. |
@lawliet89 and @tyrannosaurus-becks and @paddycarver : this is great work; we've been waiting for this. Purely an FYI: we were waiting on this so much that we enabled GitHub release notifications, but we didn't get a notification for this release. After digging, I learned that:
I suspect this also explains why the releases page doesn't emphasize release |
This breaks nomad's vault integration, it still expects |
Note to future readers: This change first appeared in version 2.2.0 of the provider. |
Update various Authentication Resources for Vault 1.2
Vault 1.2 has the change:
This causes the provider to panic when used with Vault 1.2.
This PR attempts to fix these panics by deprecating some fields and adding new ones.
TODOs:
resource_cert_auth_backend_role
Questions for @tyrannosaurus-becks :
token_
fields when updating or they get reset. I think this can be done by querying Vault for its version but it adds complexity.