Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vault_ssh_secret_backend_role resource #285

Merged
merged 5 commits into from
Jan 31, 2019

Conversation

martinssipenko
Copy link
Contributor

@martinssipenko martinssipenko commented Jan 24, 2019

This adds a new vault_ssh_secret_backend_role resource that can be used to manage SSH secret backend roles using Terraform. This does not include all the fields that are supported by resource, but should be a good start as I think having something is better than nothing.

I've ran acceptance tests I've written using a local Vault server in dev mode, output below:

make testacc TESTARGS='-run=TestAccSSHSecretBackendRole_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run=TestAccSSHSecretBackendRole_basic -timeout 120m
?   	github.com/terraform-providers/terraform-provider-vault	[no test files]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-vault/util	(cached) [no tests to run]
=== RUN   TestAccSSHSecretBackendRole_basic
--- PASS: TestAccSSHSecretBackendRole_basic (1.07s)
PASS
ok  	github.com/terraform-providers/terraform-provider-vault/vault	(cached)

make testacc TESTARGS='-run=TestAccSSHSecretBackendRole_import'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run=TestAccSSHSecretBackendRole_import -timeout 120m
?   	github.com/terraform-providers/terraform-provider-vault	[no test files]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-vault/util	(cached) [no tests to run]
=== RUN   TestAccSSHSecretBackendRole_import
--- PASS: TestAccSSHSecretBackendRole_import (1.37s)
PASS
ok  	github.com/terraform-providers/terraform-provider-vault/vault	(cached)

Fixes #246

Copy link
Contributor

@tyrannosaurus-becks tyrannosaurus-becks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@martinssipenko fantastic work. Thank you!

@tyrannosaurus-becks tyrannosaurus-becks merged commit c11f94b into hashicorp:master Jan 31, 2019
@martinssipenko martinssipenko deleted the ssh-role branch February 21, 2019 09:40
dandandy pushed a commit to dandandy/terraform-provider-vault that referenced this pull request Jun 17, 2021
Add vault_ssh_secret_backend_role resource
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants