Add accessor to the exported attributes of secret and auth mounts. #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 12, 2018 11:18
|
@jorgemarey thank you for submitting this PR! We've done a lot of updates to the vendored files since this PR was created. I bet the vendoring changes are no longer needed. Would you be willing to merge in master, clear out all the changes you've made to Once we've got that covered and pushed up, happy to do a review on this one. |
|
Hi @tyrannosaurus-becks. Of course. I'll do that |
ghost
added
the
|
Hi @tyrannosaurus-becks! It should be ok by now. All vendoring changes were no longer needed. |
tyrannosaurus-becks
approved these changes
Sep 25, 2018
dandandy
pushed a commit
to dandandy/terraform-provider-vault
that referenced
this pull request
Jun 17, 2021
Add accessor to the exported attributes of secret and auth mounts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the accessor field to the computed values of the secret and auth backend.
The resources afected by this are:
vault_mountandvault_auth_backendNow they have a new field exported named
accessor.This PR required that the vault library was upraded to a newer version.