Add minimum character constraints to random_string

[phekmat]

The motivation behind this is to more reliably create passwords that will pass complexity requirements

[mildwonkey]

LGTM!

[mildwonkey]

Thanks for adding this feature :)

[kitsunde]

This change caused all random_string created resourced to need to be recreated, which in turn was cascading through the rest of the infrastructure. If anyone else don't want to rebuild their infra you can set:

"min_lower": "0",
"min_numeric": "0",
"min_special": "0",
"min_upper": "0"

on all the random_string resources in the state file.

@mildwonkey It was surprising to me that the generate-once value forced new changes when not specifically tainted, and when it's used for resource names and such pretty disproportional to recreate the infra.

[mildwonkey]

@kitsunde I'm sorry to hear about that and thanks for sharing the workaround. I'm certain it wasn't the intent of this PR - I will take a look at it.

[martinb3]

This also bit us this morning -- huge amounts of changes due to new explicit defaults. It's also a shame since we're pinning to ~> 1.0 which means we shouldn't be seeing a dangerous change from a new feature. I'd classify it as backwards-incompatible, for semver purposes, due to the destructive nature of it.

[phekmat]

Apologies all. @mildwonkey I'm still relatively new with terraform providers, but I think the correct approach is to use a state migration to add the defaults to the instance state. I've opened a PR with that change (#29)

[mildwonkey]

Thank you @phekmat - I opened #28 just a few minutes before you with basically the same function. (I'm also new to this!) I'll close my PR; it was a good learning experience for me but we should let you own the fix.

[ChrisAnn]

This hit us too and we had a short production outage as a result 😭

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.