Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking change: SDK v2 #118

Merged
merged 9 commits into from
Oct 2, 2020
Merged

Breaking change: SDK v2 #118

merged 9 commits into from
Oct 2, 2020

Conversation

kmoe
Copy link
Member

@kmoe kmoe commented Aug 14, 2020 •
edited
Loading

This PR upgrades the provider to Terraform Plugin SDK v2.0.3 and takes the opportunity to perform the following routine maintenance tasks:

  • remove deprecated b64 attribute (necessitates major version bump)
  • match the github.com/hashicorp/terraform-provider-scaffolding directory structure
  • add attribute descriptions
  • update development Go version
  • remove outdated website builds from Makefile/CI

@kmoe kmoe requested a review from a team August 14, 2020 13:14
@ghost ghost added the size/XXL label Aug 14, 2020
@kmoe kmoe force-pushed the sdk-v2 branch 2 times, most recently from 943a143 to b866fd2 Compare September 29, 2020 16:21
@kmoe kmoe changed the title Upgrade to SDKv2 Breaking change: SDK v2 Sep 29, 2020
@kmoe kmoe requested review from paultyng and a team October 2, 2020 14:37
paultyng
paultyng approved these changes Oct 2, 2020
View reviewed changes
Copy link
Contributor

@paultyng paultyng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kmoe kmoe merged commit 19101da into master Oct 2, 2020
@kmoe kmoe deleted the sdk-v2 branch October 2, 2020 17:19
@corzine corzine mentioned this pull request Dec 8, 2022
Closed
58 tasks
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paultyng paultyng paultyng approved these changes

@paddycarver paddycarver paddycarver approved these changes

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kmoe @paddycarver @paultyng