Device import #4
Conversation
| d.Set("collector", restResponse.Data.PreferredCollectorId) | ||
| d.Set("disable_alerting", restResponse.Data.DisableAlerting) | ||
| d.Set("description", restResponse.Data.Description) | ||
| d.Set("hostgroup_id", restResponse.Data.HostGroupIds) |
There was a problem hiding this comment.
this will probably have weird implications for dynamic groups. not sure there's really much to be done about it though.
| client := m.(*lmv1.DefaultApi) | ||
|
|
||
| // if it is a deviceId, we will add the group directly | ||
| if checkID(d.Id()) { |
There was a problem hiding this comment.
is it normal provider practice accept two different possible types of resource identifiers? it's definitely convenient, just not sure if it's a normal best practice.
There was a problem hiding this comment.
im not too sure. I looked for a bit for provider best practices documentation. I know ID is usually standard but since LM doesn't make that easy for users (unless you run api calls or dig deep into the info tab), I added the second option (for ip/fqdn). Figured itd add more benefit than harm
There was a problem hiding this comment.
Makes sense. In that case, I'd probably be in favor of ditching the ID and just using the display name. No strong preference either way though.
added import functionality for devices/device groups
added vendor files using golang/dep