Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go sdk v2 initial implementation #16

Merged
merged 27 commits into from
May 6, 2019
Merged

Conversation

pyang55
Copy link
Contributor

@pyang55 pyang55 commented May 2, 2019

initial implementation of go sdk v2, all future go sdk v2 features will be branched off of this

@ghost ghost added the size/XXL label May 2, 2019
logicmonitor/config.go Outdated Show resolved Hide resolved
logicmonitor/provider.go Outdated Show resolved Hide resolved
Copy link
Contributor

@woz5999 woz5999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments requesting changes.

@pyang55 pyang55 requested a review from woz5999 May 3, 2019 17:01
logicmonitor/resource_collector_group.go Outdated Show resolved Hide resolved
logicmonitor/resource_device.go Outdated Show resolved Hide resolved
logicmonitor/resource_device_group.go Outdated Show resolved Hide resolved
@pyang55 pyang55 merged commit 78c04e9 into master May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants