-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix adding labels/annotations to resources or data to config maps/secrets when those were empty #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Acceptance test failure
|
pdecat
changed the title
[WIP] Fix adding labels to a resource that didn't have any
[WIP] Fix adding labels and annotations to a resource that didn't have any
Feb 12, 2018
pdecat
force-pushed
the
fix-adding-labels
branch
from
February 12, 2018 22:02
d082b8f
to
2efcfc9
Compare
pdecat
changed the title
[WIP] Fix adding labels and annotations to a resource that didn't have any
Fix adding labels and annotations to a resource that didn't have any
Feb 12, 2018
Unit tests result
Acceptance tests result for namespace
|
…esource that didn't have any
…o a resource that didn't have any
…fig map resource that didn't have any
pdecat
force-pushed
the
fix-adding-labels
branch
from
February 12, 2018 22:22
b4173b6
to
9140e5b
Compare
pdecat
changed the title
Fix adding labels and annotations to a resource that didn't have any
Fix adding labels/annotations to resources or data to config maps when those were empty
Feb 12, 2018
Acceptance tests result for config map:
|
pdecat
force-pushed
the
fix-adding-labels
branch
from
February 12, 2018 22:42
9140e5b
to
784924a
Compare
Acceptance tests result for secret:
|
pdecat
changed the title
Fix adding labels/annotations to resources or data to config maps when those were empty
Fix adding labels/annotations to resources or data to config maps/secrets when those were empty
Feb 12, 2018
…ret resource that didn't have any
radeksimko
approved these changes
Mar 1, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix and all attached tests @pdecat
This looks great.
Shipping... 🚢
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.