Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add data catalog tag #6550

Conversation

modular-magician
Copy link
Collaborator

Addresses #5892

It's very possible this doesn't require all the custom code and that I'm just missing some settings in api.yaml/terraform.yaml

Release Note Template for Downstream PRs (will be copied)

`data_catalog_tag`

Derived from GoogleCloudPlatform/magic-modules#3569

* add data catalog tag

* add data catalog tag

* fix missing err check

* update after review comments

* fixing a bad diff

* update per code review comments

* update fields values to camel case in ruby

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 0bc9834 into hashicorp:master Jun 8, 2020
@ghost
Copy link

ghost commented Jul 9, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 9, 2020
@modular-magician modular-magician deleted the downstream-pr-2850f2af078f69ad8bcd1c76638c9e8853def705 branch November 17, 2024 00:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant