Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include iap in appengine patch updatemask. #6216

Conversation

modular-magician
Copy link
Collaborator

Release Note Template for Downstream PRs (will be copied)

appengine: Changed `google_app_engine_application` to respect updates in `iap`

Now that 3.18 is out, I noticed that no changes to the iap block have any effect on update because we don't include "iap" in the patch update mask. This patch adds "iap" to the update mask. I can also put a little more time into this and build the update mask based on the attributes that have changed, but we're already hard-coding the mask, so I haven't changed it so far.

@chrisst @danawillow

Derived from GoogleCloudPlatform/magic-modules#3418

@ghost ghost added the size/xs label Apr 27, 2020
@modular-magician modular-magician merged commit 19575ad into hashicorp:master Apr 27, 2020
@ghost
Copy link

ghost commented May 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators May 28, 2020
@modular-magician modular-magician deleted the downstream-pr-7ceaf320f39c6f85a3a42993b44d2596bb7d39a6 branch November 16, 2024 23:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant