Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more generic error predicates #5675

Conversation

modular-magician
Copy link
Collaborator

  • Added check for Temporary() error
  • Added check for connection reset by peer error

Fixes #3957

Release Note Template for Downstream PRs (will be copied)

Added retries for common network errors we've encountered.

Derived from GoogleCloudPlatform/magic-modules#3116

* add connection reset by peer predicate

* lint

* separate error preds, fix temp pred

* Fix error retries, comments

* remove removed func

Signed-off-by: Modular Magician <[email protected]>
@ghost ghost added the size/m label Feb 13, 2020
@modular-magician modular-magician merged commit c94b6c7 into hashicorp:master Feb 13, 2020
@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
@modular-magician modular-magician deleted the downstream-pr-4033f0b1cb1193509470cb34f156ac0b1ed6972a branch November 17, 2024 00:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add retries for more network related errors
1 participant