Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set name attribute on compute_subnetwork data source #5288

Merged
merged 1 commit into from
Jan 3, 2020
Merged

Set name attribute on compute_subnetwork data source #5288

merged 1 commit into from
Jan 3, 2020

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Jan 2, 2020 •
edited by rileykarson
Loading

Previously, it was missing if self_link was used.

compute: Fixed behaviour where `google_compute_subnetwork` did not record a value for `name` when `self_link` was specified.

@ghost ghost added the size/xs label Jan 2, 2020
@ghost ghost requested review from rileykarson and tysen January 2, 2020 14:46
rileykarson
rileykarson approved these changes Jan 3, 2020
View reviewed changes
Copy link
Collaborator

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll upstream this to our code generator & then merge.

@rileykarson rileykarson mentioned this pull request Jan 3, 2020
Merged
@rileykarson rileykarson merged commit b3e83db into hashicorp:master Jan 3, 2020
@ghost
Copy link

ghost commented Feb 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Feb 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rileykarson rileykarson rileykarson approved these changes

@tysen tysen Awaiting requested review from tysen

Assignees
No one assigned
Labels
size/xs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelbeaumont @rileykarson