Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AppEngine locations #3674

Merged
merged 2 commits into from
May 23, 2019
Merged

Update AppEngine locations #3674

merged 2 commits into from
May 23, 2019

Conversation

letic
Copy link
Contributor

@letic letic commented May 21, 2019

I needed to use Zurich (europe-west6) for a project and terraform wouldn't accept it.

So here is a simple patch to update AppEngine locations with latest from Google official documentation located at : https://cloud.google.com/appengine/docs/locations

Cheers
LeTic

@ghost ghost added the size/xs label May 21, 2019
@letic
Copy link
Contributor Author

letic commented May 21, 2019

Error details during Terraform plan :
Error: google_app_engine_application.xxxxx-dev: expected location_id to be one of [northamerica-northeast1 us-central us-west2 us-east1 us-east4 southamerica-east1 europe-west europe-west2 europe-west3 asia-northeast1 asia-south1 australia-southeast1], got europe-west6

@danawillow danawillow self-requested a review May 21, 2019 19:20
@danawillow
Copy link
Contributor

Thanks @letic! I'm fairly sick of having to keep this list up-to-date, and it doesn't quite feel like it's worth having the validation for something that we keep having to change like this. Mind just ripping it out entirely?

@letic
Copy link
Contributor Author

letic commented May 23, 2019

Hey @danawillow sorry about the delay.

Here's a version without the region validation function. Simple enough should be easy to merge.

Take care
LeTic

Copy link
Contributor

@danawillow danawillow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No delay at all! Thanks @letic, appreciate it :)

danawillow pushed a commit to danawillow/magic-modules that referenced this pull request May 23, 2019
@danawillow danawillow merged commit fef12cc into hashicorp:master May 23, 2019
modular-magician pushed a commit to danawillow/magic-modules that referenced this pull request May 23, 2019
@letic
Copy link
Contributor Author

letic commented May 24, 2019

No worries. Thanks for the good work :)

@ghost
Copy link

ghost commented Jun 23, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants