Correct usage of 'folders' for 'google_folder_organization_policy' resource

[ewbankkit]

The folders argument to the google_folder_organization_policy resource has to be the folder's resource name in the format folders/{folder_id}.
Correct the documentation.

[ewbankkit]

What do you think to using canonicalFolderId to handle either just the folder ID or the full resource name?

[rosbo]

I think we should definitely use the canonicalFolderId method here. Do you want to add it in this PR?

[ewbankkit]

Yes, I can do that (and re-title the PR).

[ewbankkit]

No need to change the PR title 😄.
Acceptance tests:

make testacc TEST=./google/ TESTARGS='-run=TestAccGoogleFolderOrganizationPolicy_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./google/ -v -run=TestAccGoogleFolderOrganizationPolicy_ -timeout 120m
=== RUN   TestAccGoogleFolderOrganizationPolicy_boolean
=== RUN   TestAccGoogleFolderOrganizationPolicy_list_allowAll
=== RUN   TestAccGoogleFolderOrganizationPolicy_list_allowSome
=== RUN   TestAccGoogleFolderOrganizationPolicy_list_denySome
=== RUN   TestAccGoogleFolderOrganizationPolicy_list_update
--- PASS: TestAccGoogleFolderOrganizationPolicy_boolean (34.51s)
--- PASS: TestAccGoogleFolderOrganizationPolicy_list_update (16.31s)
--- PASS: TestAccGoogleFolderOrganizationPolicy_list_denySome (15.00s)
--- PASS: TestAccGoogleFolderOrganizationPolicy_list_allowSome (15.03s)
--- PASS: TestAccGoogleFolderOrganizationPolicy_list_allowAll (14.18s)
PASS
ok  	github.com/terraform-providers/terraform-provider-google/google	95.037s

[rosbo]

You should also call this method at line 73 and 91 to ensure the create, delete and update method also work.

Can you also update one of the acceptance test to use the id only for the folder field:

resource "google_folder_organization_policy" "list" {
  folder     = "replace(${google_folder.orgpolicy.name}, 'folders/','')
  ...

[ewbankkit]

Done.

[ewbankkit]

Rebased and squashed.

[ewbankkit]

Travis CI go vet error - #968.

[ewbankkit]

Rebased again after merge of #969.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!