Fix update when changing health check type #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--- PASS: TestAccComputeHealthCheck_typeTransition (68.51s) |
| Config: testAccComputeHealthCheck_tcp(hckName), | ||
| }, | ||
| resource.TestStep{ | ||
| Config: testAccComputeHealthCheck_https(hckName), |
There was a problem hiding this comment.
So, the problem was that it wasn't possible to switch types, and this confirms that the type changes work?
nat-henderson
approved these changes
Jan 12, 2018
modular-magician
added a commit
to modular-magician/terraform-provider-google
that referenced
this pull request
Sep 27, 2019
Signed-off-by: Modular Magician <[email protected]>
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #92
When updating health check type, we have to make sure the previous health check type block is set to the json null value.