-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistent IAM resource imports. #835
Conversation
- Projects and folders can have bindings, members, and policies imported. - Anything else with IAM can implement a simple method and begin working immediately. Still TODO: - tests - documentation - KMS crypto key - KMS key ring
The import tests pass on my machine with my org / project combo. |
google/iam.go
Outdated
|
||
type resourceIdParserFunc func(d *schema.ResourceData, config *Config) error | ||
|
||
func iamPolicyImport(resourceIdParser resourceIdParserFunc) schema.StateFunc { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider moving the iamPolicyImport
, iamPolicyBinding
and iamPolicyMember
functions into their respective resource_iam_*
file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call! Done.
Build is failing because of unused or missing imports after the move. |
Fixed that - should have tried a test after that. :) |
Add consistency for for IAM imports. - Adds imports for projects, folders, crypto keys, organizations, and key rings. - Anything else with IAM can implement a simple method and begin working immediately. - Add tests for all the IAM imports. - Import documentation for IAM resources.
Signed-off-by: Modular Magician <[email protected]>
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Fixes #756