Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for min_cpu_platform to instance_template #808

Merged
merged 3 commits into from
Dec 1, 2017

Conversation

rosbo
Copy link
Contributor

@rosbo rosbo commented Nov 30, 2017

Fixes #516

--- PASS: TestAccComputeInstanceTemplate_minCpuPlatform (24.27s)
--- PASS: TestAccComputeInstanceTemplate_preemptible (24.30s)
--- PASS: TestAccComputeInstanceTemplate_address (24.31s)
--- PASS: TestAccComputeInstanceTemplate_basic (24.33s)
--- PASS: TestAccComputeInstanceTemplate_networkIP (24.33s)
--- PASS: TestAccComputeInstanceTemplate_primaryAliasIpRange (24.33s)
--- PASS: TestAccComputeInstanceTemplate_importBasic (24.33s)
--- PASS: TestAccComputeInstanceTemplate_disks (24.34s)
--- FAIL: TestAccComputeInstanceTemplate_subnet_xpn (0.24s)

@@ -524,6 +530,7 @@ func resourceComputeInstanceTemplateCreate(d *schema.ResourceData, meta interfac
instanceProperties.CanIpForward = d.Get("can_ip_forward").(bool)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

totally up to you, but while you're here I wouldn't mind having these set inline in the struct:

instanceProperties := &computeBeta.InstanceProperties{
// stuff
}

Config: testAccComputeInstanceTemplate_minCpuPlatform(acctest.RandString(10)),
Check: resource.ComposeTestCheckFunc(
testAccCheckComputeInstanceTemplateExists("google_compute_instance_template.foobar", &instanceTemplate),
testAccCheckComputeInstanceTemplateHasMinCpuPlatform(&instanceTemplate, "Intel Haswell"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May as well just make "Intel Haswell" a var that gets passed into the config and the check

@rosbo rosbo merged commit 12baa87 into hashicorp:master Dec 1, 2017
@rosbo rosbo deleted the min-cpu-instance-tmpl branch December 1, 2017 20:03
modular-magician added a commit to modular-magician/terraform-provider-google that referenced this pull request Sep 27, 2019
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for min_cpu_platform in google_compute_instance_template.
2 participants