Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate account_id length in google_service_account #793

Merged
merged 4 commits into from
Nov 28, 2017
Merged

Validate account_id length in google_service_account #793

merged 4 commits into from
Nov 28, 2017

Conversation

rosbo
Copy link
Contributor

@rosbo rosbo commented Nov 27, 2017

Fixes #791

Failing at plan time is always better than failing at apply time whenever we can. Additionally, the error returned by the API when the account_id is incorrect is unhelpful: Error creating service account: googleapi: Error 400: Request contains an invalid argument., badRequest

cc/ @benbro

@rosbo rosbo requested a review from danawillow November 27, 2017 18:10
danawillow
danawillow reviewed Nov 28, 2017
View reviewed changes
google/resource_google_service_account.go Outdated
Type: schema.TypeString,
Required: true,
ForceNew: true,
ValidateFunc: validation.StringLenBetween(6, 30),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we do have some more information on what a valid id is, let's just go ahead and check the regexp: https://cloud.google.com/iam/reference/rest/v1/projects.serviceAccounts/create

It is unique within a project, must be 6-30 characters long, and match the regular expression a-z to comply with RFC1035.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@rosbo rosbo merged commit d4c5a71 into hashicorp:master Nov 28, 2017
@rosbo rosbo deleted the service-account-id branch November 28, 2017 01:58
@danawillow
Copy link
Contributor

Looks like this broke TestAccGoogleServiceAccountKey_basic and TestAccGoogleServiceAccountKey_pgp

@rosbo rosbo mentioned this pull request Nov 28, 2017
Merged
@danawillow danawillow mentioned this pull request Nov 29, 2017
Closed
modular-magician added a commit to modular-magician/terraform-provider-google that referenced this pull request Sep 27, 2019
@modular-magician
Add machine_type to dataflow_job (hashicorp#793)
570cc44 
Signed-off-by: Modular Magician <[email protected]>
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danawillow danawillow danawillow approved these changes

Assignees

@danawillow danawillow

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

google_service_account account_id should be between 6 and 30 characters
2 participants
@rosbo @danawillow