Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IAM binding and member support for organizations #775

Merged
merged 2 commits into from
Nov 21, 2017

Conversation

rosbo
Copy link
Contributor

@rosbo rosbo commented Nov 21, 2017

Fixes #485

cc/ @ubschmidt2

@rosbo
Copy link
Contributor Author

rosbo commented Nov 21, 2017

--- PASS: TestAccGoogleProjectIamBinding_basic (27.21s)
--- PASS: TestAccGoogleProjectIamBinding_multipleAtOnce (28.24s)
--- PASS: TestAccGoogleProjectIamBinding_remove (30.37s)
--- PASS: TestAccGoogleProjectIamBinding_multiple (32.62s)
--- PASS: TestAccGoogleProjectIamBinding_update (35.29s)
--- PASS: TestAccGoogleOrganizationIamCustomRole_import (2.67s)
--- PASS: TestAccGoogleOrganizationIamCustomRole_basic (3.88s)
--- PASS: TestAccGoogleOrganizationIamCustomRole_undelete (4.97s)
--- PASS: TestAccGoogleOrganizationIam (12.43s)

role = "${google_organization_iam_custom_role.test-role.id}"
members = [
"serviceAccount:${google_service_account.test-account.email}",
"serviceAccount:${google_service_account.test-account-2.email}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: indentation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

}),
},
{
// Test Iam Member creation (no update for member, no need to test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: missing end paren

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@rosbo rosbo merged commit e70d1fc into hashicorp:master Nov 21, 2017
@rosbo rosbo deleted the org-iam-policies branch November 21, 2017 22:30
chrisst pushed a commit to chrisst/terraform-provider-google that referenced this pull request Nov 9, 2018
modular-magician added a commit to modular-magician/terraform-provider-google that referenced this pull request Sep 27, 2019
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for configuring IAM policies at the organization-level
2 participants